add selfstake bucket index in candidate #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
- Coverage 58.65% 58.63% -0.03%
==========================================
Files 182 182
Lines 15320 15324 +4
==========================================
- Hits 8986 8985 -1
- Misses 5212 5216 +4
- Partials 1122 1123 +1
Continue to review full report at Codecov.
|
dustinxie
reviewed
Feb 29, 2020
action/protocol/staking/candidate.go
Outdated
| Reward: reward, | ||
| Name: name, | ||
| Votes: big.NewInt(0), | ||
| SelfStakeIdx: selfStakeIdx, |
There was a problem hiding this comment.
nit: move to end? so it is consistent with proto order
CoderZhi
approved these changes
Feb 29, 2020
action/protocol/staking/candidate.go
Outdated
| Reward address.Address | ||
| Name string | ||
| Votes *big.Int | ||
| SelfStakeIdx uint64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.