Remove x/nft enum declaration #252
Assignees
Comments
Merged
husio
added a commit
that referenced
this issue
Jan 7, 2019
Protobuf generated `Action` enum is replaced by a custom `Action` string type. This refactoring does not introduce and external API changes. Both JSON and binary format is kept. resolve #252
This was referenced Jan 7, 2019
alpe
pushed a commit
that referenced
this issue
Jan 11, 2019
* refactor `x/nft.Action` type Protobuf generated `Action` enum is replaced by a custom `Action` string type. This refactoring does not introduce and external API changes. Both JSON and binary format is kept. resolve #252 * use regexp to validate nft action string We do not know the full list of possible nft actions, so when validating an action name, we can only ensure that if follows certain naming scheme. * Redo nft actions registration. Instead of using regexp to validate an action, provide a global action index where all actions must be registered before using. * statically register default nft actions Instead of using init function, statically register all actions that support for is implemented by the nft extension. * add actions to app.go * add default actions array * fix nft tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
x/nftwe are using enum as a const. There is no need for this enum declaration as it is not part of any protobuf message. We can declare those values as const strings in Go code instead.Such change will reduce the amount of code, remove confusing protobuf enum declaration and keep action names constant to avoid typos.
The text was updated successfully, but these errors were encountered: