Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nft/username to be used alone #282

Closed
ethanfrey opened this issue Jan 22, 2019 · 6 comments · Fixed by #312
Closed

Allow nft/username to be used alone #282

ethanfrey opened this issue Jan 22, 2019 · 6 comments · Fixed by #312
Assignees

Comments

@ethanfrey
Copy link
Contributor

Right now, it enforces a contraint that all registered (ChainId, Address) pairs contain a ChainId that refers to a Blockchain NFT that is already registered.

As part of the launch requirements, we will only launch with Username management, and not Blockchain management, as there are some security/design issues that need much deeper thinking before we can start on them.

Therefore, we need to make sure that nft/username (which will be used on launch) can work without any other nfts being present.

I do understand that this will allow arbitrary chainIds into the database, and we will never be able to enforce the relation for "legacy" data. Please bring up concerns on that issue here as well

@ethanfrey
Copy link
Contributor Author

Open discussion with @alpe

  • What is chainId? network id? blockchain id?
  • how do we enforce whitelist?

@husio
Copy link
Contributor

husio commented Jan 23, 2019

Is this story about changing current cmd/bnsd/x/nft/username or creating a new implementation from scratch?
I both cases, I believe we should remove everything else from cmd/bnsd/x/nft. Thanks to Git, it can be revived later if needed.

@ethanfrey
Copy link
Contributor Author

It is about modifying current x/nft/username (I believe it is not under cmd/bnsd)

I think it just removes an import and a constraint.
Existing version is in git history when/if we want to implement whitelisting again

@husio
Copy link
Contributor

husio commented Jan 23, 2019

All nft implementations (except for the nft itself) were moved to bnsd https://github.com/iov-one/weave/tree/master/cmd/bnsd/x/nft/username

@ethanfrey
Copy link
Contributor Author

I guess I have an old version of weave checked out...
I'll do a git pull

@ethanfrey
Copy link
Contributor Author

Ahh.... I was looking at 2 week old code, didn't realize you moved it Friday

husio added a commit that referenced this issue Feb 12, 2019
Remove all dependency of other nft packages from nft/username. This
greatly simplify the implementation as requested in #282

resolve #282
husio added a commit that referenced this issue Feb 12, 2019
Remove all dependency of other nft packages from nft/username. This
greatly simplify the implementation as requested in #282

resolve #282
husio added a commit that referenced this issue Feb 12, 2019
Remove all dependency of other nft packages from nft/username. This
greatly simplify the implementation as requested in #282

resolve #282
husio added a commit that referenced this issue Feb 12, 2019
Remove all dependency of other nft packages from nft/username. This
greatly simplify the implementation as requested in #282

resolve #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants