New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tendermint upgrade #266
Tendermint upgrade #266
Conversation
Tendermint is upgraded to 0.27.4. This change introduce a regression in weave/store/iavl package.
Upgrade of tendermint to version 0.27.4 requires update of the genesis file in order to work again.
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
======================================
Coverage 70.8% 70.8%
======================================
Files 142 142
Lines 6272 6272
======================================
Hits 4443 4443
Misses 1393 1393
Partials 436 436 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No code needed to change for abci?
"max_age": "100000" | ||
}, | ||
"validator": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one.
is there docs on all this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some mentions in the release changelog, but I was just looking at the code to figure this out.
Documentation is mentioning some of those fields, but it does not explain where they are in the genesis file, which makes the whole documentation useless.
🎉 |
resolve #206
I had to update genesis files in order to pass the tests. I am not sure if new configuration makes sense, but I believe it is good enough for tests.