Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tendermint upgrade #266

Merged
merged 4 commits into from Jan 9, 2019
Merged

Tendermint upgrade #266

merged 4 commits into from Jan 9, 2019

Conversation

husio
Copy link
Contributor

@husio husio commented Jan 8, 2019

resolve #206

I had to update genesis files in order to pass the tests. I am not sure if new configuration makes sense, but I believe it is good enough for tests.

husio and others added 3 commits January 8, 2019 14:02
Tendermint is upgraded to 0.27.4. This change introduce a regression in
weave/store/iavl package.
Upgrade of tendermint to version 0.27.4 requires update of the genesis
file in order to work again.
@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #266   +/-   ##
======================================
  Coverage    70.8%   70.8%           
======================================
  Files         142     142           
  Lines        6272    6272           
======================================
  Hits         4443    4443           
  Misses       1393    1393           
  Partials      436     436

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12715a...3e33be7. Read the comment docs.

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
No code needed to change for abci?

"max_age": "100000"
},
"validator": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one.
is there docs on all this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some mentions in the release changelog, but I was just looking at the code to figure this out.
Documentation is mentioning some of those fields, but it does not explain where they are in the genesis file, which makes the whole documentation useless.

@alpe
Copy link
Contributor

alpe commented Jan 9, 2019

🎉
The config changes to the test genesis are also used in TM examples: https://github.com/tendermint/tendermint/blob/master/docs/tendermint-core/using-tendermint.md#sample-genesisjson

@alpe alpe merged commit c3ea9f6 into master Jan 9, 2019
@alpe alpe deleted the tendermint_upgrade branch January 9, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to tendermint 0.27.4
4 participants