-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/bnscli: use mnemonic to generate private key #923
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b74eecc
cmd/bnscli: use mnemonic to generate private key
husio ef5fb9f
bnscli: validate mnemonic before using
husio 88f43b2
update bnscli key management
husio 93f3406
CHANGELOG
husio 4b19844
bnscli: mnemonic tests
husio fd82cc9
bnscli: improve mnemonic validation
husio d370993
ensure mnemonic whitespace does not influence output
husio 0094cae
more bip-39 package issues solved
husio d94e1c2
fix bnscli tests
husio File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ import ( | |
"errors" | ||
"fmt" | ||
"io" | ||
"io/ioutil" | ||
"os" | ||
"strconv" | ||
"strings" | ||
|
@@ -182,3 +183,22 @@ func tendermintStore(nodeURL string) weave.ReadOnlyKVStore { | |
tm := rpcclient.NewHTTP(nodeURL, "/websocket") | ||
return app.NewABCIStore(rpcQueryWrapper{tm}) | ||
} | ||
|
||
// readInput returns all bytes waiting on given input. This function immediatly | ||
// returns errNoPipe error if the input is not piped to avoid forever waiting. | ||
func readInput(input io.Reader) ([]byte, error) { | ||
// If the given reader is providing a stat information (ie os.Stdin) | ||
// then check if the data is being piped. That should prevent us from | ||
// waiting for a data on a reader that no one ever writes to. | ||
if s, ok := input.(stater); ok { | ||
if info, err := s.Stat(); err == nil { | ||
isPipe := (info.Mode() & os.ModeCharDevice) == 0 | ||
if !isPipe { | ||
return nil, errNoPipe | ||
} | ||
} | ||
} | ||
return ioutil.ReadAll(input) | ||
} | ||
|
||
var errNoPipe = errors.New("no data piped") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. req: Please move const and vars before the methods using them. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pp: please add default path to the description so that it can be copied and modified knowing our exact format and numbers if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default is always printed as part of the help message.