Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing fields in Get #34

Closed
fntlnz opened this issue Jan 14, 2019 · 0 comments · Fixed by #63
Closed

Implement missing fields in Get #34

fntlnz opened this issue Jan 14, 2019 · 0 comments · Fixed by #63
Labels
good first issue Good for newcomers
Milestone
First release

Comments

@fntlnz
Copy link
Member

fntlnz commented Jan 14, 2019

Status ad age are missing fields in the table printed out on a kubectl trace get

kubectl-trace/pkg/cmd/get.go

Line 189 in be030c8

fmt.Fprintf(w, "\n"+format, j.Namespace, j.Hostname, j.Name, "<missing>", "<missing>")

Those fields can be inferred by getting status and age from the related trace's job.
@fntlnz fntlnz added this to the First release milestone Jan 14, 2019
@fntlnz fntlnz added the good first issue Good for newcomers label Jan 15, 2019
@jerr jerr mentioned this issue Mar 1, 2019
Merged
@fntlnz fntlnz closed this as completed in #63 Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
First release
Development

Successfully merging a pull request may close this issue.

feat: Implement missing fields in Get jerr/kubectl-trace
1 participant
@fntlnz