Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement missing fields in Get #63

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

jerr
Copy link
Contributor

@jerr jerr commented Mar 1, 2019

Add Status and age fields in the table printed out on a kubectl trace get

Attempt to fix #34

Example of use:

$ kubectl trace get
NAMESPACE	NODE		NAME							STATUS		AGE	
default		kind-worker2	kubectl-trace-f2db30bc-3c3e-11e9-a337-9cb6d0de1923	Running		27s	
default		kind-worker1	kubectl-trace-f4dbd43e-3c3e-11e9-8c3c-9cb6d0de1923	Completed	24s	

Here we have two traces, one running and the other completed.

We can also add other fields such as duration but I am not sure that it is very useful.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

Copy link
Member

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice! 😮

@fntlnz fntlnz merged commit 12b88dd into iovisor:master Mar 1, 2019
@fntlnz
Copy link
Member

fntlnz commented Mar 1, 2019

Thanks for doing this @jerr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing fields in Get
2 participants