Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for oidc auth on Kubernetes #28

Merged
merged 2 commits into from
Jan 12, 2019
Merged

Conversation

alban
Copy link
Contributor

@alban alban commented Jan 11, 2019

Symptoms:

kubectl trace run $NODE_NAME -e "tracepoint:syscalls:sys_enter_* { @[probe] = count(); }"
Error: No Auth Provider found for name "oidc"

The client/auth/oidc pkg in client-go is not vendored. This patch adds the blank import.

Signed-off-by: Alban Crequy alban@kinvolk.io

@alban
Copy link
Contributor Author

alban commented Jan 11, 2019

@schu suggested I try to delete my GOPATH/pkg/mod and try again, and it worked. I will update the PR.

Symptoms:

```
$ kubectl trace run $NODE_NAME -e "tracepoint:syscalls:sys_enter_* { @[probe] = count(); }"
Error: No Auth Provider found for name "oidc"
```

The client/auth/oidc pkg in client-go is not vendored. This patch adds
the blank import.

Signed-off-by: Alban Crequy <alban@kinvolk.io>
Update vendoring with the command `go mod vendor`.

Signed-off-by: Alban Crequy <alban@kinvolk.io>
@alban
Copy link
Contributor Author

alban commented Jan 11, 2019

PR updated.

@leodido leodido self-requested a review January 11, 2019 17:30
Copy link
Member

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alban

LGTM

@fntlnz fntlnz merged commit 3392e93 into iovisor:master Jan 12, 2019
@alban alban deleted the alban/oidc branch January 14, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants