Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build instructions result in build errors #361

Closed
dthaler opened this issue Oct 18, 2023 · 0 comments · Fixed by #362
Closed

Build instructions result in build errors #361

dthaler opened this issue Oct 18, 2023 · 0 comments · Fixed by #362

Comments

@dthaler
Copy link
Collaborator

dthaler commented Oct 18, 2023

https://github.com/iovisor/ubpf#checking-out says:

git submodule init
git submodule update --recursive

However that only does an init at the top level, not recursively, and as a result elfio is not initialized and so the build fails.

Instead the two lines should be replaced with one line:

git submodule update --init --recursive

Which indeed is what the CICD actually does.

dthaler added a commit that referenced this issue Oct 18, 2023
This PR updates the PR with the correct command to initialize
submodules recursively.

Fixes #361

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Alan-Jowett pushed a commit that referenced this issue Oct 18, 2023
This PR updates the PR with the correct command to initialize
submodules recursively.

Fixes #361

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant