Updates from latest release #23
Conversation
|
I commented the dependency to |
| @@ -20,7 +20,7 @@ | |||
| <exec_depend>language-pack-en</exec_depend> | |||
| <exec_depend>language-pack-de</exec_depend> | |||
| <exec_depend>openssh-server</exec_depend> | |||
| <exec_depend>chromium-browser</exec_depend> | |||
| <!--exec_depend>chromium-browser</exec_depend--> | |||
There was a problem hiding this comment.
the purpose for the desktop variant is to provide everything we use on a normal development machine. This includes a lot of thing which are not ROS or robot related, e.g. meld, tree, bride, latex, chromium.
so I vote for adding chormium to rosdistro and readd it as a dependency here.
There was a problem hiding this comment.
What's the rosdep key for fedora then? chromium-stable?
There was a problem hiding this comment.
no idear? can't you skip fedora in the release process? are all other cob_* packages successfully released for fedora?
There was a problem hiding this comment.
Yes, they are. At least it seems like it.
During release, it tells me that the fedora rosdep key is not found...it also offers me to skip, but has a very thorough warning saying only to do so in case I'm absolutely sure that the key is not available in fedora...this is why I did not skip it 😉
|
I'll merge this and revert the commented chromium line afterwards |
chromium-browseris not in the rosdep.yaml....and I don't know whether it should be added there...why do we needchromium-browseras a dependency? @ipa-fmw @ipa-nhg