Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi distro travis #79

Merged
merged 12 commits into from
Mar 20, 2017
Merged

Multi distro travis #79

merged 12 commits into from
Mar 20, 2017

Conversation

fmessmer
Copy link
Member

@fmessmer fmessmer commented Mar 5, 2017 •
edited

replaces #77

tested CI locally: OK

ipa320/kinetic_dev branch should be removed after merge!
(see indigo_dev...kinetic_dev)
the libpcan-update has been backported to indigo_dev in #78

This was referenced Mar 5, 2017
Closed
Merged
@fmessmer
Copy link
Member Author

fmessmer commented Mar 5, 2017

need to take care of @ipa-mdl's suggestions ipa320/cob_people_perception#56 (comment)

@fmessmer
Copy link
Member Author

fmessmer commented Mar 5, 2017

also consider https://github.com/ipa320/cob_driver/pull/323#issuecomment-284230720

@floweisshardt floweisshardt mentioned this pull request Mar 5, 2017
Closed
@fmessmer fmessmer mentioned this pull request Mar 9, 2017
Merged
@fmessmer
Copy link
Member Author

we'll need to incorporate changes from #81 and refactor the other packages similarly

@fmessmer fmessmer mentioned this pull request Mar 15, 2017
Merged
@fmessmer
Copy link
Member Author

Travis succeeds, however, I see the following warning for all packages:

catkin_package() DEPENDS on 'EP_libpcan' but neither

  'EP_libpcan_INCLUDE_DIRS' nor 'EP_libpcan_LIBRARIES' is defined.

@ipa-mdl something we need to worry about/can fix?

@mathias-luedtke
Copy link
Contributor

something we need to worry about/can fix?

Yes, this is wrong.
EXPORTED_TARGETS EP_${PROJECT_NAME} should be used.

@fmessmer
Copy link
Member Author

EXPORTED_TARGETS solved the issue

ipa-nhg
ipa-nhg approved these changes Mar 20, 2017
View reviewed changes
Copy link
Member

@ipa-nhg ipa-nhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust Travis, didn't review each CMakeLists file

@fmessmer fmessmer merged commit 2342f0d into ipa320:indigo_dev Mar 20, 2017
@fmessmer fmessmer deleted the multi_distro_travis branch March 20, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipa-nhg ipa-nhg ipa-nhg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmessmer @mathias-luedtke @ipa-nhg