[Melodic] #38
Merged
[Melodic] #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmessmer
previously approved these changes
Aug 1, 2019
There was a problem hiding this comment.
I can confirm that the plugin still works for kinetic - when using https://github.com/ipa320/cob_common/pull/271
This was referenced Aug 1, 2019
Closed
fmessmer
previously approved these changes
Aug 1, 2019
fmessmer
reviewed
Aug 2, 2019
There was a problem hiding this comment.
I see the following warning:
[ WARN] [1564736237.339278403, 0.469000000]: The default_robot_hw_sim plugin is using the Joint::SetPosition method without preserving the link velocity.
[ WARN] [1564736237.339305046, 0.469000000]: As a result, gravity will not be simulated correctly for your model.
[ WARN] [1564736237.339321186, 0.469000000]: Please set gazebo_pid parameters, switch to the VelocityJointInterface or EffortJointInterface, or upgrade to Gazebo 9.
[ WARN] [1564736237.339335329, 0.469000000]: For details, see https://github.com/ros-simulation/gazebo_ros_pkgs/issues/612
this might not necessarily be related to this PR, but I would like to investigate before merging
floweisshardt
previously approved these changes
Aug 2, 2019
|
maybe we can do something like this: ros-simulation/gazebo_ros_pkgs#550 |
|
@benmaidel please re-test this branch with melodic simulation to help me verify the dual-distro compatibility...thx |
fmessmer
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ipa320/care-o-bot#52
superseeds #37
I've removed the last commit from @ompugao concerning the pid interface because of @fmessmer comment #37 (review)
This should be compatible with kinetic and melodic if the
hardware_interfaceprefix is used for all transmissions.