Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: robot_footprint_frame rosparam #117

Merged
merged 1 commit into from
Aug 10, 2020
Merged

feat: robot_footprint_frame rosparam #117

merged 1 commit into from
Aug 10, 2020

Conversation

AravindaDP
Copy link
Contributor

Support setting robot_footprint_frame as a rosparam (issues/116)
(defaults to "base_footprint")

Support setting robot_footprint_frame as a rosparam (issues/116)
(defaults to "base_footprint")
Copy link
Member

@floweisshardt floweisshardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and does not change default behavior

@floweisshardt floweisshardt merged commit 7eed163 into ipa320:indigo_dev Aug 10, 2020
@AravindaDP
Copy link
Contributor Author

@floweisshardt Thanks for merging. Any idea when this would find it's way to ubuntu apt repository for melodic?

I guess from our side we need to prepare a new release from ros-build farm and then it's up to ros package maintainer to include it in next release cycle?

@AravindaDP AravindaDP deleted the feat/cob_linear_nav_footprint_tf_param branch August 11, 2020 03:52
@AravindaDP AravindaDP restored the feat/cob_linear_nav_footprint_tf_param branch August 11, 2020 03:52
@floweisshardt
Copy link
Member

the next release is not scheduled yet. Maybe not before September/October

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded frame name base_footprint in odometryCB function
2 participants