added libxi and libxmu as dependencies for ros build farm #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the ROS build farm is fine with all the packages. You can merge. |
fmessmer
approved these changes
Mar 13, 2017
libnite2/CMakeLists.txt
Outdated
| DESTINATION ${CATKIN_GLOBAL_INCLUDE_DESTINATION} | ||
| #install(DIRECTORY common/include | ||
| # DESTINATION ${CATKIN_GLOBAL_INCLUDE_DESTINATION} | ||
| #) |
There was a problem hiding this comment.
I changed it. The new code is written directly below, without comments. I just left the old code because I was not sure whether the new one or the old one is correct. If you tell me which is right, I will just delete the other.
So do we take option 1 or 2:
1.
install(DIRECTORY common/include
DESTINATION ${CATKIN_GLOBAL_INCLUDE_DESTINATION})
install(DIRECTORY common/include/${PROJECT_NAME}/
DESTINATION ${CATKIN_PACKAGE_INCLUDE_DESTINATION}
FILES_MATCHING PATTERN "*.h"
PATTERN ".svn" EXCLUDE
)
There was a problem hiding this comment.
ok, 2 is fine - we discussed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe this fixes the build farm error - please do not merge until approved by me