Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsolete dependencies to cmake_modules #75

Merged
merged 1 commit into from
Jul 19, 2017
Merged

remove obsolete dependencies to cmake_modules #75

merged 1 commit into from
Jul 19, 2017

Conversation

fmessmer
Copy link
Member

found during kinetic migration

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Jul 11, 2017

Just for curiosity, why is cmake_modules not needed in those packages?

@fmessmer
Copy link
Member Author

fmessmer commented Jul 11, 2017 •
edited
Loading

because cmake_modules is only relevant in case one of the documented packages is used (see https://github.com/ros/cmake_modules/blob/0.4-devel/README.md) ....but I found none of those packages being used...thus cmake_modules is an oboslete dependency...

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Jul 11, 2017

Ah ok, thanks for this information. Good to know. Then I misunderstood the meaning of this cmake_modules so far.

@fmessmer
Copy link
Member Author

Ah ok, thanks for this information. Good to know. Then I misunderstood the meaning of this cmake_modules so far.

that's why it's all over the place...:wink:

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Jul 11, 2017

Indeed.

@fmessmer
Copy link
Member Author

@ipa-rmb ping

@ipa-rmb ipa-rmb merged commit 32e912f into indigo_dev Jul 19, 2017
@fmessmer fmessmer deleted the remove_obsolete_cmake_modules branch July 19, 2017 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floweisshardt floweisshardt floweisshardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmessmer @ipa-rmb @floweisshardt