Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3dof head for cob4-1 within simulation only #414

Merged
merged 5 commits into from
Feb 12, 2016

Conversation

floweisshardt
Copy link
Member

superceeds #413

  • adds default_robot_behaviour to simulation
  • fixes head poses

@fmessmer
Copy link
Member

so according to @ipa-nhg's comment, parameters with the name X_button where X is a component that does not exist for the respective robot are not needed....

this is also the case for e.g. raw's....they have minimall teleop.yaml with just the buttons needed for base

thus, one last question for this PR:
should we "clean up" the teleop.yaml for cob's so that parameters X_button are removed in case component X is not part of the robot?

I also added a bullet to issue https://github.com/ipa320/cob_command_tools/issues/112 regarding "component name"-independent parameter names...

@floweisshardt
Copy link
Member Author

+1 for cleaning up unused button parameters, but in a separate PR --> see issue #416
+1 for merging this one

@ipa-nhg
Copy link
Member

ipa-nhg commented Feb 11, 2016

FR: OK

floweisshardt pushed a commit that referenced this pull request Feb 12, 2016
add 3dof head for cob4-1 within simulation only
@floweisshardt floweisshardt merged commit 7740046 into ipa320:indigo_dev Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants