Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on linux headers #218

Merged

Conversation

christian-rauch
Copy link
Collaborator

Similar to ipa320/cob_extern#100, remove the dependency on the linux headers for schunk_powercube_chain.
I don't see any reference to the linux headers in the schunk_powercube_chain other than "Added linux-headers-generic as dependency" in https://github.com/ipa320/schunk_modular_robotics/blob/kinetic_dev/schunk_powercube_chain/CHANGELOG.rst#068-2016-10-10.

I really want to remove the old kernel and headers but keep the Schunk packages :-)

@christian-rauch
Copy link
Collaborator Author

@fmessmer It seems after changing the default branches (#216 (comment)) I no longer have the rights to merge PR and push to branches. Can you check that I still have the necessary access rights to the schunk_modular_robotics repo?

@fmessmer
Copy link
Member

@christian-rauch you still have Write access...but the approval for this pr was missing...try it again now...
were you able to push without approval last time? maybe the branch protection rule did not yet apply to kinetic_dev at that time...
CI checks and Review approval are required for this repo...only "Admin" can force merge...

@christian-rauch
Copy link
Collaborator Author

Ok, I am able to merge now.

I believe (and I might be wrong about this) that I was able to merge #216 and #217 without additional approval.

@christian-rauch christian-rauch merged commit 3711c62 into ipa320:kinetic_dev Nov 18, 2019
@christian-rauch christian-rauch deleted the rm_dep_linux_header branch November 18, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants