New GetNumberOfIterations method in planning problem #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxmerkt
reviewed
Jun 19, 2019
wxmerkt
reviewed
Jun 19, 2019
wxmerkt
reviewed
Jun 19, 2019
wxmerkt
reviewed
Jun 20, 2019
* static_cast in planning_problem * get_num_ -> get_number_of_
wxmerkt
approved these changes
Jun 20, 2019
wxmerkt
pushed a commit
that referenced
this pull request
Jun 22, 2020
* [core/python] new GetNumberOfIterations method in planning problem * [core/python] Updated post-review. * static_cast in planning_problem * get_num_ -> get_number_of_ * [core] Minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method to get the number of iterations, rather than
now,
Not sure why but in
GetNumberOfIterationsimplementation I tried to returncost_evolution_.size()but this gave incorrect values. An explanation would be interesting to know.