Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing bind files with ipaddress #50

Closed
wants to merge 76 commits into from
Closed

Conversation

mabels
Copy link

@mabels mabels commented Sep 8, 2014

Hello,

i used ipaddress to write name server configuration. And there is the reverse function very handy but
to write a complete file you need to write a SOA record which contains a shorter string than fqdn. So
i added the function to generate these special strings for ipv4 and ipv6.

On that way a added function to ipv6 which allows the same like supernet/subnet in ipv4.

cheers

meno

mabels and others added 4 commits September 8, 2014 12:49
to ask addresses for the reverve domain names which are used
in the SOA Records.
There are subnet/supernet functions in ipv4 this was missing in
ipv6. I decided not to use the same api in ipv6, instead i added a
function called each_net which loops over all nets.
@mabels
Copy link
Author

mabels commented Oct 24, 2014

Hello,

i refactored the summarize function that is works with ipv4 and ipv6.

There are some pull requests pending, it would be nice if you just give me a small notice that you are willing to integrate these fixes/enhancemens. If you are not planning to integrate these fixes i need to start my own branch of ipaddress.

Meno

@francisluong
Copy link
Contributor

@mabels: this is out of scope for ipaddress and really deserves its own gem. No reason you couldn't use ipaddress as a dependency. Closing without reviewing or committing.

@mabels
Copy link
Author

mabels commented Sep 10, 2016

@francisluong this was opened in 2014.
I totally agree with your todays decision. I forked ipaddress around that time, and my branch is now running a:
cpp
javascript
rust
implementation with the same api. Thx for the api, but i will continue my own branch.

Please don't feel offened!

thx

meno

@francisluong
Copy link
Contributor

👍

@mabels
Copy link
Author

mabels commented Sep 10, 2016

during my work to port the stuff i changed the object structure so that there is no ipv4 or ipv6 specific object. Due to this i abstracted the most of the functions to now one implementation in the ipaddress class.
Currently i did not backported that changes to ruby but if you are interessed?
I would do the backport in my branch, if you take in account to merge this back to your version 2-:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants