Possible Bug in the Definition of the Hash Structure

[Iridescent-Xuan]

I'm learning the awesome work of IPC, and I really appreciate your generous contribution to this toolkit!

But when compiling the unordered_map_and_set.hpp (I don't set the abseil option, so the Hash structure is defined separately), some warning from GCC occurs, which says that the Hash::combine function is "returning reference to temporary". If I ignore the warning from compiler, segmentation fault happens when running into this line.

I'm not quite familiar with std::move or Rvalue reference, but I think there might be something wrong in this line, where you seem to return the reference of a temporary Hash variable.

[zfergus]

PR #90 should fix this issue for you.

[Iridescent-Xuan]

PR #90 should fix this issue for you.

Thanks a lot!