Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing files or invalid fixture scripts? #27

Closed
gmlewis opened this issue Sep 30, 2021 · 3 comments
Closed

Missing files or invalid fixture scripts? #27

gmlewis opened this issue Sep 30, 2021 · 3 comments

Comments

@gmlewis
Copy link

gmlewis commented Sep 30, 2021

I tried some of the examples in the "fixtures" directory, and the simulator works great! Nice work!

However, I discovered that there are some examples that don't run either because their mesh files don't exist in the repo or because of some other problem.

For example, this example is missing its meshes:
https://github.com/ipc-sim/rigid-ipc/blob/main/fixtures/3D/mechanisms/expanding-lock-box.json#L11-L57

This example says [2021-09-30 19:57:28.039] [error] Invalid Json file:
https://github.com/ipc-sim/rigid-ipc/blob/main/fixtures/2D/compactor.json

@zfergus
Copy link
Member

zfergus commented Oct 1, 2021

Glad to hear it is working well for you.

The lockbox model was one that we bought here and used in our paper, but we do not have the rights to distribute it, unfortunately. I left the JSON fixture in the repo simply to provide the setup and parameters used in our paper. Maybe I will add a note about this in the README.

As for the broken JSON files, that is most likely a find-replace that left a trailing comma at the end of an object. JSON is annoying about that. Thanks for pointing me to that file. I will fix it and try to check all the files can be read.

@zfergus
Copy link
Member

zfergus commented Oct 1, 2021

Fixed

@gmlewis
Copy link
Author

gmlewis commented Oct 1, 2021

Thank you again!

@gmlewis gmlewis closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants