Fix #495: Hijack proxy /add correctly. Disable keep-alives. #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
hsanjuan
added
need/review
No more hacks around /add. This uses the local adder when hijacking /add. It supports the parameters and works pretty well with the ipfs CLI, showing progress and everything. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
This uses Join rather than PeerAdd. Join ensures a DHT bootstrap after successfully joining. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
See discussion in ipfs/kubo#5168 We cannot stream responses with keep-alives enabled. I prefer this to not be a client feature, as otherwise users might end up shooting themselves in the foot. Note, the price is a corrupted request body which gets added normally and gives wrong hashes! License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
fix/495-proxy-add
branch
from
8d52f1e
to
be651da
Compare
|
Related to why we need to disable keep alives for adding to work correctly: ipfs/kubo#5168 |
hsanjuan
changed the title
lanzafame
suggested changes
Aug 20, 2018
| @@ -0,0 +1,68 @@ | |||
| // Package adderutils provides some utilities for adding content to cluster. | |||
There was a problem hiding this comment.
I not sure this really requires being in its own utils package... Unless I am missing an import cycle, I believe this could simply be a function in the adder package.
There was a problem hiding this comment.
yeah, import cycle :(. adder[utils] -> local -> adder
lanzafame
approved these changes
Aug 20, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more hacks around /add. This uses the local adder when hijacking /add.
It supports the parameters and works pretty well with the ipfs CLI, showing
progress and everything.
#495