This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
suggested changes
Feb 22, 2018
package.json
Outdated
"release-minor": "node --max-old-space-size=8192 node_modules/.bin/aegir release --type minor ", | ||
"release-major": "node --max-old-space-size=8192 node_modules/.bin/aegir release --type major ", | ||
"coverage": "node --max-old-space-size=8192 node_modules/.bin/aegir coverage --timeout 100000", | ||
"coverage-publish": "anode --max-old-space-size=8192 node_modules/.bin/aegir coverage --provider coveralls --timeout 100000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dryajov why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$()
breaks windows as it is a unix shell (bash?) thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
805bd8d
to
5d4f538
Compare
daviddias
reviewed
Feb 23, 2018
"release-minor": "cross-env NODE_OPTIONS='--max-old-space-size=8192' aegir release --type minor ", | ||
"release-major": "cross-env NODE_OPTIONS='--max-old-space-size=8192' aegir release --type major ", | ||
"coverage": "cross-env NODE_OPTIONS='--max-old-space-size=8192' aegir coverage --timeout 100000", | ||
"coverage-publish": "cross-env NODE_OPTIONS='--max-old-space-size=8192' aegir coverage --provider coveralls --timeout 100000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
5d4f538
to
3b4f093
Compare
daviddias
approved these changes
Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.