Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.2.0 #29

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Release 0.2.0 #29

merged 2 commits into from
Mar 24, 2024

Conversation

Arlodotexe
Copy link
Collaborator

@Arlodotexe Arlodotexe commented Mar 23, 2024

[Breaking]

  • IDataBlock.DataStream was removed. This pattern encouraged async calls behind synchronous property getters, which is a bad practice and can cause deadlocks. Call the async methods directly on the API instead.
  • The obsolete IFileSystemApi.ListFileAsync was removed due to prior deprecation and removal in Kubo 0.26.0. Use IFileSystemApi.ListAsync and MfsApi.StatAsync instead. See [META] Commands Library Improvements ipfs/kubo#7493 (comment).

[New]

[Breaking]
IDataBlock.DataStream was removed. This pattern encouraged async calls behind synchronous property getters, which is a bad practice and can cause deadlocks. Call the async methods directly on the API instead.
The obsolete IFileSystemApi.ListFileAsync was removed due to prior deprecation and removal in Kubo 0.26.0. Use IFileSystemApi.ListAsync and MfsApi.StatAsync instead. See ipfs/kubo#7493 (comment).

[New]
Added missing IFileSystemApi.ListAsync. Doesn't fully replace the removed IFileSystemApi.ListFileAsync, but is a step in the right direction. See ipfs/kubo#7493 (comment).
@Arlodotexe Arlodotexe self-assigned this Mar 23, 2024
Arlodotexe added a commit to ipfs-shipyard/net-ipfs-http-client that referenced this pull request Mar 23, 2024
[Breaking]
Inherited breaking changes from IpfsShipyard.Ipfs.Core 0.2.0.
IDataBlock.DataStream was removed. This pattern encouraged async calls behind synchronous property getters, which is a bad practice and can cause deadlocks. Call the async methods directly on the API instead.
The obsolete IFileSystemApi.ListFileAsync was removed due to prior deprecation and removal in Kubo 0.26.0. Use IFileSystemApi.ListAsync and MfsApi.StatAsync instead.

[New]
Added missing IFileSystemApi.ListAsync. Doesn't fully replace the removed IFileSystemApi.ListFileAsync, but is a step in the right direction.

See also ipfs-shipyard/net-ipfs-core#29
@Arlodotexe Arlodotexe merged commit bdc52b4 into main Mar 24, 2024
1 check passed
@Arlodotexe Arlodotexe deleted the rel/0.2.0 branch March 24, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant