Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing @types/mdast dep #1445

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: add missing @types/mdast dep #1445

merged 1 commit into from
Jan 12, 2024

Conversation

SgtPooki
Copy link
Member

resolves multiple errors of error TS2307: Cannot find module 'mdast' or its corresponding type declarations.

@SgtPooki
fix: npm run test succeeds
f5de0fd 
resolves multiple errors of error TS2307: Cannot find module 'mdast' or its corresponding type declarations.
@SgtPooki SgtPooki self-assigned this Jan 10, 2024
@achingbrain
Copy link
Member

Where are you seeing this failing?

@achingbrain achingbrain changed the title fix: npm run test succeeds fix: add missing @types/mdast dep Jan 12, 2024
achingbrain
achingbrain approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use mdast in type annotations so looks like we need the extra dep.

@achingbrain achingbrain merged commit 1a3dffc into master Jan 12, 2024
20 checks passed
@achingbrain achingbrain deleted the fix/test-run branch January 12, 2024 14:08
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
@semantic-release-bot
chore(release): 42.1.3 [skip ci]
b8c8996 
## [42.1.3](v42.1.2...v42.1.3) (2024-01-12)

### Bug Fixes

* add missing @types/mdast dep ([#1445](#1445)) ([1a3dffc](1a3dffc))
* remove premove and merge-options ([#1449](#1449)) ([889b03a](889b03a)), closes [#1434](#1434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees

@SgtPooki SgtPooki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SgtPooki @achingbrain