Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using cat instead of get #54

Merged
merged 6 commits into from
Dec 10, 2018
Merged

Using cat instead of get #54

merged 6 commits into from
Dec 10, 2018

Conversation

litzenberger
Copy link
Contributor

Replaced the IPFS get method with cat for local extract test.

@ghost ghost assigned litzenberger Dec 8, 2018
@ghost ghost added the status/in-progress In progress label Dec 8, 2018
@litzenberger litzenberger mentioned this pull request Dec 8, 2018
Closed
Elexy
Elexy approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@Elexy Elexy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the difference is but LGTM

mcollina
mcollina reviewed Dec 8, 2018
View reviewed changes
tests/local-extract.js Outdated Show resolved Hide resolved
@ghost ghost assigned mcollina Dec 10, 2018
@litzenberger litzenberger merged commit 3149421 into verify-files Dec 10, 2018
@ghost ghost removed the status/in-progress In progress label Dec 10, 2018
@litzenberger litzenberger deleted the cat-tests branch December 12, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

@Elexy Elexy Elexy approved these changes

Assignees

@mcollina mcollina

@litzenberger litzenberger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@litzenberger @mcollina @Elexy