Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch gateway code to new API from boxo #57

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Mar 6, 2023

Relies on ipfs/boxo#176 and related PRs.

Closes #60.

@hacdias hacdias requested review from hacdias and lidel March 9, 2023 10:13
@hacdias hacdias force-pushed the feat/golibipfs-gateway-refactor branch 2 times, most recently from 2c0669a to 0f3de62 Compare March 14, 2023 14:10
@hacdias hacdias self-assigned this Mar 14, 2023
@aschmahmann aschmahmann mentioned this pull request Mar 21, 2023
13 tasks
@hacdias hacdias changed the title feat: update go-libipfs and switch to use its blocks-gateway implementation refactor: switch gateway code to new API from go-libipfs Mar 21, 2023
@hacdias hacdias force-pushed the feat/golibipfs-gateway-refactor branch from 0f3de62 to 7c783c5 Compare March 21, 2023 10:58
@hacdias hacdias marked this pull request as ready for review March 21, 2023 10:58
@hacdias hacdias force-pushed the feat/golibipfs-gateway-refactor branch from a26351b to 7c783c5 Compare March 21, 2023 13:05
@aschmahmann aschmahmann force-pushed the feat/golibipfs-gateway-refactor branch from 7c783c5 to dce7280 Compare March 21, 2023 20:43
@lidel lidel changed the title refactor: switch gateway code to new API from go-libipfs refactor: switch gateway code to new API from boxo Mar 27, 2023
@lidel lidel force-pushed the feat/golibipfs-gateway-refactor branch from dce7280 to 955bcd5 Compare March 29, 2023 13:20
@lidel
Copy link
Member

lidel commented Mar 29, 2023

@aschmahmann @hacdias FYSA I am using this PR to migrate bifrost-gateway and caboose (filecoin-saturn/caboose#68) to boxo.

This way we will be able to rebase #61 and have that PR limited to switching from blocks to CARs, without the noise related to boxo rename.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, conformance tests are green, local ab and h2load tests passed, which I think is good enough.

I'm merging to unblock #61 (we will do more in-depth testing there).

@lidel lidel merged commit fd484ac into main Mar 29, 2023
@lidel lidel deleted the feat/golibipfs-gateway-refactor branch March 29, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

Support DNSLink on ENS (move namesys defaults out of Kubo)
3 participants