This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
go-ipfs 0.4.4 has been released #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbenet
suggested changes
Oct 12, 2016
| Pinned objects wouldn't be directly affected, but they wouldn't be protected from | ||
| garbage collection anymore. | ||
|
|
||
| We recently discovered a bug in the logic of our pinning code. Because of this |
There was a problem hiding this comment.
thank @kyledrake explicitly, for finding and reporting this.
| issue with the recursive hash trie implementation caused hash table buckets to | ||
| be overwritten resulting in only 256 pins remaining in the pinset. After that, | ||
| the bug won't be triggered again until the number of pins again exceeds 8192. | ||
| The 256 pins that remain are random. |
There was a problem hiding this comment.
add a paragraph on the fix. include:
- how we fixed it
- how we (stress) test that this no longer happens
- commitment to redouble efforts to make all our test suites more robust to ensure these kinds of problems do not happen.
- remind users not to run
ipfs repo gcon sensitive data that is not otherwise backed up, as IPFS is still not 1.0 and our development may still find problems.
|
@lgierth and @whyrusleeping: can you review my changes? |
|
@RichardLitt I added a few more. @whyrusleeping @Kubuxu either of you have a last look too. Btw we need to fix building ipfs-see-all from source, which is mentioned as an option in the post. Rendered version: https://ipfs.io/ipfs/QmXarD5t3EDffn4nRtqVTcd6bJq5v5wFTErcLFxtg5MYk2/21-go-ipfs-0-4-4-released/ |
|
Ping @Kubuxu @whyrusleeping for a last fact-checking review. |
|
@Kubuxu @whyrusleeping @RichardLitt any updates? We should be able to ship this now. |
|
LGTM |
|
Great. Let's go! @lgierth publish? |
ghost
merged commit 
ghost
added
status/in-progress
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "bug" and "find out if you're affected" sections still need a bit of wording polish.
cc @jbenet @whyrusleeping @RichardLitt