Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway: ipfs_http_gw_get_duration_seconds metric is not updated #162

Closed
lidel opened this issue Feb 10, 2023 · 1 comment · Fixed by #167
Closed

gateway: ipfs_http_gw_get_duration_seconds metric is not updated #162

lidel opened this issue Feb 10, 2023 · 1 comment · Fixed by #167
Assignees
@hacdias
Labels
kind/bug A bug in existing code (including security flaws) topic/gateway Issues related to HTTP Gateway

Comments

@lidel
Copy link
Member

lidel commented Feb 10, 2023 •
edited

https://github.com/ipfs/go-libipfs/blob/1c6ed2e96f7753a3452607e2a429311a31099cf4/gateway/handler.go#L240-L242

It should be updated for every request type (global histogram across all response types), does not seem to be happening atm
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Feb 10, 2023
@lidel lidel mentioned this issue Feb 10, 2023
Open
@hacdias
Copy link
Member

hacdias commented Feb 13, 2023 •
edited

@lidel it seems to be updating on my side (tried multiple formats, both under ipfs and ipns). The count increases 1 with every successful request. Do you have any example of requests that do not update this metric?

Funnily enough, it updates with every successful request except for actual UnixFS files 🥲 I'll fix this.

This was referenced Feb 13, 2023
Merged
Merged
@hacdias hacdias added topic/gateway Issues related to HTTP Gateway and removed need/triage Needs initial labeling and prioritization labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
kind/bug A bug in existing code (including security flaws) topic/gateway Issues related to HTTP Gateway
Projects
No open projects
bifrost-gateway
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gateway): ensure ipfs_http_gw_get_duration_seconds gets updated ipfs/boxo
2 participants
@lidel @hacdias