fix(gateway): ensure ipfs_http_gw_get_duration_seconds gets updated #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 19.62% 19.62%
=======================================
Files 100 100
Lines 11053 11052 -1
=======================================
Hits 2169 2169
+ Misses 8597 8596 -1
Partials 287 287
|
|
CI failures seem to be related to 8c06779. it's being worked in Kubo. |
lidel
requested changes
Feb 14, 2023
There was a problem hiding this comment.
ack. we need to make decision what to do with failing sharness, not having it is risk, not having correct metrics is also bad.
Let's wait for answer on ipfs/kubo#9643 (comment)
lidel
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #155 I overlooked where I was returning the success status and ended up returning
falsefor all UnixFS files. I added more nested success status returning so the metric is more accurate now. Closes #162.