Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: return user-friendly HTML with HTTP errors #262

Closed
11 tasks
lidel opened this issue Apr 5, 2023 · 0 comments · Fixed by #298
Closed
11 tasks

gateway: return user-friendly HTML with HTTP errors #262

lidel opened this issue Apr 5, 2023 · 0 comments · Fixed by #298
Assignees
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week P1 High: Likely tackled by core team if no one steps up topic/gateway Issues related to HTTP Gateway

Comments

@lidel
Copy link
Member

lidel commented Apr 5, 2023

Currently, we return text/plain with context of err.Error() of some sort. This if fine for curl, but very user hostile in web browser context.

Proposed improvement

basic human needs (#298)

nice to have

below could be a follow-up PR. may not be a good idea to hardcode another HTTP endpoint and use of https://pl-diagnose.onrender.com for every gateway deployment, perhaps better to wait for ipfs/in-web-browsers#207 and webtransport transport rollout. or we could use https://pl-diagnose.onrender.com and https://cid.contact/ as default, with config options to change/disable them.

@lidel lidel added P1 High: Likely tackled by core team if no one steps up dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week topic/gateway Issues related to HTTP Gateway labels Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week P1 High: Likely tackled by core team if no one steps up topic/gateway Issues related to HTTP Gateway
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants