Migrate go-unixfs into unixfs/ipld-merkledag #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch> This commit was moved from ipfs/go-unixfs@b736dc1
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch> This commit was moved from ipfs/go-unixfs@72df8b2
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch> This commit was moved from ipfs/go-unixfs@d6e8b60
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch> This commit was moved from ipfs/go-unixfs@b845e42
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch> This commit was moved from ipfs/go-unixfs@91871b4
License: MIT Signed-off-by: Jeromy <why@ipfs.io> This commit was moved from ipfs/go-unixfs@b4c08b0
*** THIS IS A BREAKING CHANGE *** as per [1]: "Required is forever" Nevertheless this seems like a good idea at this time: there are no known producers ( nor consumers ) of MetaData nodes, and the current requirement of MimeType has an extremely narrow application scope. This change could very well be rejected in lieu of implementing a new type of node ( e.g. TheRealMetadata ) in the DataType enum. Based on ipfs/kubo#3451 (comment) License: MIT Signed-off-by: Mib Kd743naq <mib.kd743naq@gmail.com> [1] https://developers.google.com/protocol-buffers/docs/proto#specifying-field-rules This commit was moved from ipfs/go-unixfs@e94be52
License: MIT Signed-off-by: Zander Mackie <zmackie@gmail.com> This commit was moved from ipfs/go-unixfs@63cfd75
License: MIT Signed-off-by: Zander Mackie <zmackie@gmail.com> This commit was moved from ipfs/go-unixfs@2e3a9f7
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@4df1387
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@a3e7230
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@a0f5ffd
License: MIT Signed-off-by: Jeromy <why@ipfs.io> This commit was moved from ipfs/go-unixfs@21a5430
License: MIT Signed-off-by: Jeromy <why@ipfs.io> This commit was moved from ipfs/go-unixfs@c9a8a08
License: MIT Signed-off-by: Jeromy <why@ipfs.io> This commit was moved from ipfs/go-unixfs@ba636f0
License: MIT Signed-off-by: Jeromy <why@ipfs.io> This commit was moved from ipfs/go-unixfs@a6f8ee7
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@bd3637a
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch> This commit was moved from ipfs/go-unixfs@8bf6483
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@5e8347c
fix: multiple govet warnings This commit was moved from ipfs/go-unixfs@12d16cb
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@1f3adf3
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@123b0fd
…n nil License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@c1e9ccd
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@957da2c
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@e19161f
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@fb78dc2
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@a01e57d
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@4f4ba29
License: MIT Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com> This commit was moved from ipfs/go-unixfs@ee18aaa
License: MIT Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com> This commit was moved from ipfs/go-unixfs@427d991
hacdias
reviewed
Jan 25, 2023
hacdias
reviewed
Jan 25, 2023
hacdias
reviewed
Jan 25, 2023
|
Notes: |
Jorropo
added a commit
that referenced
this pull request
Jan 26, 2023
Jorropo
added a commit
that referenced
this pull request
Jan 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 18.50% 27.55% +9.04%
==========================================
Files 96 110 +14
Lines 10337 12967 +2630
==========================================
+ Hits 1913 3573 +1660
- Misses 8152 8899 +747
- Partials 272 495 +223
|
Jorropo
force-pushed
the
unixfs
branch
4 times, most recently
from
dfae82e
to
e74087b
Compare
This is needed because the unixfs tests imports go-block-format.
Jorropo
removed
the
status/blocked
go.mod & go.sum conflict resolution
|
I hope the use of the name "merkledag" in this doesn't mean you're intending to pull in go-merkledag .. we really need that package to be retired over time, not baked in to some official thing |
|
@rvagg, I havn't thought about The main goal of naming it |
|
@rvagg it's on the list ipfs/kubo#8543 (comment) 🤷 |
|
🤦 we're never going to kill these repos .. just shuffle them around, making breaking changes, aggravating our ecosystem; this is not a great idea. It might serve Kubo nicely, but I don't see how it serves anyone else. |
Resolve conflicts
|
Not doing that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple and will have more unixfs implementations in the future.
So I think it could make sense to start migrating them like this, so the import path tells you which abstraction you are using. (
go-unixfsnodewould beunixfs/ipld-prime).Depends on (include) #58
Depends on ipfs/go-block-format#37
Todo:
go.modwith a tagged release once refactor: deprecate and add stub types to go-libipfs/blocks go-block-format#37 is released.