Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: run perfsprint #521

Merged
merged 2 commits into from
Dec 8, 2023
Merged

all: run perfsprint #521

merged 2 commits into from
Dec 8, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Dec 8, 2023 •
edited
Loading

Help #67

@Jorropo Jorropo requested review from lidel, hacdias and a team as code owners December 8, 2023 10:24
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

Merging #521 (b48c418) into main (ba5ba1a) will decrease coverage by 0.08%.
The diff coverage is 49.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   65.57%   65.49%   -0.08%     
==========================================
  Files         207      207              
  Lines       25543    25549       +6     
==========================================
- Hits        16749    16734      -15     
- Misses       7323     7340      +17     
- Partials     1471     1475       +4
Files Coverage Δ
...ernal/providerquerymanager/providerquerymanager.go 86.30% <100.00%> (-2.49%) ⬇️
bitswap/client/internal/tracing.go 100.00% <100.00%> (ø)
bitswap/internal/testutil/testutil.go 55.12% <100.00%> (ø)
bitswap/internal/tracing.go 100.00% <100.00%> (ø)
...swap/server/internal/decision/blockstoremanager.go 91.01% <100.00%> (ø)
blockservice/internal/tracing.go 100.00% <100.00%> (ø)
gateway/assets/node.go 55.95% <100.00%> (ø)
gateway/errors.go 83.33% <100.00%> (ø)
gateway/gateway.go 85.03% <100.00%> (ø)
gateway/lazyseek.go 79.41% <100.00%> (ø)
... and 32 more

... and 9 files with indirect coverage changes

Jorropo
Jorropo commented Dec 8, 2023
View reviewed changes
bitswap/client/internal/sessionmanager/sessionmanager_test.go Outdated Show resolved Hide resolved
bitswap/internal/testutil/testutil.go Outdated Show resolved Hide resolved
bitswap/server/internal/decision/blockstoremanager.go Outdated Show resolved Hide resolved
gateway/handler_unixfs_file.go Outdated Show resolved Hide resolved
gateway/metrics.go Outdated Show resolved Hide resolved
ipld/unixfs/io/directory.go Outdated Show resolved Hide resolved
keystore/keystore.go Outdated Show resolved Hide resolved
mfs/file.go Outdated Show resolved Hide resolved
namesys/republisher/repub.go Outdated Show resolved Hide resolved
namesys/utilities.go Outdated Show resolved Hide resolved
@Jorropo Jorropo merged commit 483bc39 into main Dec 8, 2023
14 checks passed
@Jorropo Jorropo deleted the perfsprint branch December 8, 2023 11:36
@hacdias
Copy link
Member

hacdias commented Dec 8, 2023

Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel Awaiting requested review from lidel lidel is a code owner

@hacdias hacdias Awaiting requested review from hacdias

Assignees
No one assigned
Labels
skip/changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jorropo @hacdias