Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.21.0 #622

Merged
merged 11 commits into from
Jun 21, 2024
Merged

Release v0.21.0 #622

merged 11 commits into from
Jun 21, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 20, 2024

This is me following the process from https://github.com/ipfs/boxo/blob/main/RELEASE.md#release-process (minus creating issue with the checklist, I'm doing the checklist below).

Initial impression: we could simplify a lot of manual labor by switching to release-please, and doing patch releases if needed by hand, rather than doing everything by hand. We will discuss once this one ships the old way.


  • Create a release branch called release-vX.Y.Z and push it
    • Use master as base if Z == 0
    • Use release as base if Z > 0
  • Tidy the changelog and push any changelog changes to release-vX.Y.Z
  • Create a draft PR merging release-vX.Y.Z into release
    • Name it "Release vX.Y.Z"
    • Reference this release issue
  • If Z > 0, then cherry-pick the necessary commits from master into release-vX.Y.Z using git cherry-pick -x <commit>
  • Ensure Boxo tests are passing
  • Ensure Kubo tests are passing
    • Go to Kubo dir and run go get github.com/ipfs/boxo@<commit_hash> using the commit hash of the release-vX.Y.Z branch
    • Run go mod tidy in repo root and in docs/examples/kubo-as-a-library
    • Commit the changes and open a draft PR in Kubo
    • Name the PR "Upgrade to Boxo vX.Y.Z"
    • Paste a link to the Kubo PR in the Boxo PR, so reviewers can verify the Kubo test run
    • Verify the CI passes (chore: update dependencies incl. boxo v0.21.0 kubo#10444)
  • Add a commit in release-vX.Y.Z bumping the version in version.json to vX.Y.Z
  • Add a "release" label to the Boxo PR
  • After the release checker creates a draft release, copy-paste the changelog into the draft
  • Wait for approval from another Boxo maintainer
  • Merge the PR into release, using "Create a Merge Commit", and do not delete the release-vX.Y.X branch
    • Verify the tag is created
  • Announce the release
    • Click this link to start a new Discourse topic
      • Update vX.Y.Z in the title and body
      • Create the topic
  • Create a PR merging release into main
    • Name it "Merge release vX.Y.Z"
    • Wait for approval
    • Merge it using "Create a Merge Commit", and do not delete the release branch
  • Update the Kubo PR to use the newly released version, mark it as "Ready for Review", get approval, and merge into Kubo

hacdias and others added 9 commits May 24, 2024 08:19
I've noticed some memory and goroutine buildup, linked to that function.

It seems like when the context get cancelled, the consumer could be gone, but that function would still attempt to write in the channel and block forever.
* fix(routing/http/contentrouter): return error when no responses are found in FindPeer
* fix(routing/http/contentrouter): fix findpeer iteration log message
* fix(routing/http/contentrouter): only return information for FindPeer that matches the requested peerID
* fix(routing/http/contentrouter): only return information for FindPeer if there are actual addresses
* fix(routing/http/contentrouter): switch logging from Warnw -> Warnf where there aren't key pairs
* docs: update CHANGELOG.md

---------

Co-authored-by: Marcin Rataj <lidel@lidel.org>
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 63.57143% with 51 lines in your changes missing coverage. Please review.

Project coverage is 59.81%. Comparing base (980447e) to head (4eec0e4).

Impacted file tree graph

@@             Coverage Diff             @@
##           release     #622      +/-   ##
===========================================
- Coverage    59.83%   59.81%   -0.02%     
===========================================
  Files          239      238       -1     
  Lines        29961    29984      +23     
===========================================
+ Hits         17928    17936       +8     
- Misses       10419    10431      +12     
- Partials      1614     1617       +3     
Files Coverage Δ
...ernal/providerquerymanager/providerquerymanager.go 87.45% <100.00%> (-1.35%) ⬇️
bitswap/client/internal/session/session.go 91.15% <100.00%> (+0.09%) ⬆️
routing/http/contentrouter/contentrouter.go 50.56% <63.15%> (+1.42%) ⬆️
examples/car-file-fetcher/main.go 38.88% <38.88%> (ø)

... and 15 files with indirect coverage changes

This comment was marked as resolved.

@lidel lidel added the release Merging this PR will create a tagged release label Jun 20, 2024
@lidel lidel mentioned this pull request Jun 20, 2024
go get -t -u ./...
Copy link

Suggested version: v0.21.0

Comparing to: v0.20.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
go.mod: the following requirements are needed
	go.opentelemetry.io/otel/exporters/jaeger@v1.14.0
Run 'go mod tidy' to add missing requirements.
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.20.1

gocompat says:

Your branch is up to date with 'origin/release'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to release. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

lidel added a commit to ipfs/kubo that referenced this pull request Jun 20, 2024
@lidel lidel marked this pull request as ready for review June 20, 2024 23:53
@lidel lidel requested a review from a team as a code owner June 20, 2024 23:53
@lidel
Copy link
Member Author

lidel commented Jun 21, 2024

Ok, took some notes in #623 on the process, but no blockers, all green.

Shipping and bubbling up to kubo/rainbow/someguy, so we can tag releases of the last two next week.

@lidel lidel merged commit 9555624 into release Jun 21, 2024
23 checks passed
@lidel lidel mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Merging this PR will create a tagged release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants