Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wantlist overflow handling to select newer entries. #627

Closed
wants to merge 1 commit into from

Conversation

gammazero
Copy link
Contributor

bitswap wantlist overflow handling now selects newer entries when truncating wantlist. This fix prevents the retained portion of the wantlist from filling up with CIDs that the server does not have.

Fixes #527

@gammazero gammazero requested a review from a team as a code owner June 21, 2024 08:24
bitswap wantlist overflow handling now selects newer entries when truncating wantlist. This fix prevents the retained portion of the wantlist from filling up with CIDs that the server does not have.

Fixes #527
@gammazero gammazero force-pushed the fix/wantlist-overflow-handling branch from 2ecdad2 to 0126d1f Compare June 21, 2024 08:27
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (dfd4a53) to head (0126d1f).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   59.79%   59.83%   +0.03%     
==========================================
  Files         238      238              
  Lines       29984    29983       -1     
==========================================
+ Hits        17930    17939       +9     
+ Misses      10434    10427       -7     
+ Partials     1620     1617       -3     
Files Coverage Δ
bitswap/server/internal/decision/engine.go 91.75% <100.00%> (+0.53%) ⬆️

... and 12 files with indirect coverage changes

@gammazero gammazero marked this pull request as draft June 23, 2024 04:17
@gammazero
Copy link
Contributor Author

Need different approach. Old entries need to be canceled.

@gammazero gammazero closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitswap/server: wantlist overflows fails in a toxic maner preventing any data transfer
1 participant