Skip to content

Commit

Permalink
Change Coode Review and Merge sections
Browse files Browse the repository at this point in the history
Updated to show Needs Review - we dont use LFCR anymore. And added my name instead of @jbenet for requests for help with merges.
  • Loading branch information
RichardLitt committed Oct 31, 2016
1 parent 7bfa1e7 commit d133317
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions contribution-guidelines.md
Expand Up @@ -194,12 +194,7 @@ Pull requests descriptions should be as clear as possible. Err on the side of ov

We take code quality seriously; we must make sure the code remains correct. We do code review on all changesets. Discuss any comments, then make modifications and push additional commits to your feature branch. Be sure to post a comment after pushing. The new commits will show up in the pull request automatically, but the reviewers will not be notified unless you comment.

We use `LFCR` (Looking For Code Review) as a signal that something needs review. For example:

```
I addressed the comments. The gateway now returns cache headers.
@jbenet LFCR
```
We use the `needs review` as a signal that something needs review. If you can't add one to your own PR, feel free to request that the maintainers add the label to it.

### Rebasing

Expand All @@ -209,7 +204,7 @@ Before the pull request is merged, make sure that you squash your commits into l

### Merge Approval

We use LGTM (Looks Good To Me) in comments on the code review to indicate acceptance. A change **requires** LGTMs from the maintainers of each component affected. If you know whom it may be, ping them. If not, ping [@jbenet](https://github.com/jbenet).
We use LGTM (Looks Good To Me) in comments on the code review to indicate acceptance. A change **requires** LGTMs from the maintainers of each component affected. If you know whom it may be, ping them. If not, ping [@RichardLitt](https://github.com/RichardLitt).

### Reverting Changes

Expand Down

0 comments on commit d133317

Please sign in to comment.