This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
feat: improved CID column (filename and dnslink support) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for some reason `-e` gets interpreted literally at CI. This removes its use making the output look the same everywhere. CI will now show diff if uncommited changes to make it easier to see what caused CI to fail.
lidel
force-pushed
the
fix/links-when-dnslink
branch
from
ea4e54a
to
b12c35a
Compare
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Sep 28, 2020
This switches go-ipfs to dir-index-html from ipfs/dir-index-html#43
jessicaschilling
approved these changes
Sep 28, 2020
|
@jessicaschilling I don't expect more changes here, so this is ready to be reviewed (and if looks good, to be released). |
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Sep 28, 2020
This switches go-ipfs to dir-index-html after ipfs/dir-index-html#43 got merged to master
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #42 by taking advantage of
DNSLinkflag added in ipfs/kubo#7699Changes:
?filename=param to preserve name and content typehttp://cid.ipfs.io#<cid>-eto<style>block,npm run buildshould now produce same output on all unix platforms