feat: add t0122 - tar #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(moving into its own PR to simplify discussion about #25 (comment)) |
This was referenced Mar 31, 2023
galargh
requested changes
Mar 31, 2023
There was a problem hiding this comment.
Following up on #25 (comment)
With the addition of shell, I'm afraid we'd introduce a whole world of undefined dependencies, we'd increase the bar for understanding tests because now you also have to be proficient with bash, and we'd add a whole lot of code that's very hard to test. I'd consider all of these to be discouraging for contributors.
One of the core goals of the project is to make the tests more reliable. In my opinion, this would defeat this purpose completely.
laurentsenta
force-pushed
the
feat/add-t0122
branch
from
278b868
to
671878b
Compare
laurentsenta
force-pushed
the
feat/add-t0122
branch
from
0619a76
to
01ebd9d
Compare
feat: add test 109
galargh
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #26