-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: feat/t0116 gateway cache.sh #30
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galargh
force-pushed
the
feat/t0116-gateway-cache.sh
branch
from
April 4, 2023 09:55
054e520
to
2f9adaf
Compare
20 tasks
(removing myself while this is still in draft) |
For what it's worth, it's never getting out of draft but I'm keeping it alive to remember to salvage parts of it that are still relevant. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ends up doing a bit more than I intended at first. It:
SugarTests
the default for defining tests - 5dde175SugarTests
the only option for defining tests - 72453bc and cdddcc9Provider
interface (think `StringProvider(value).Get() rather than using value directly) - 284e1e6I mentioned some of the interesting commits up here. I think looking at it that way is much more convenient. We can definitely discuss this in person too!
Feedback is more than welcome.
I think embracing SugarTests would let us simplify quite a bit of the internals.
The way I implemented information sharing between requests... I'm not 100% convinced.
Other things for consideration:
Finally, important to note that this PR doesn't enable IPNS test cases.