Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ➕ Add pull_request_template to all helia* repos. #182

Merged
merged 14 commits into from
Feb 1, 2024

Conversation

whizzzkid
Copy link
Contributor

Summary

Adding pull request template for all helia* projects.

Why do you need this?

For the sake of consistency

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
@whizzzkid whizzzkid requested a review from a team as a code owner December 7, 2023 07:12
@whizzzkid whizzzkid requested a review from a team as a code owner December 7, 2023 07:13
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the pr template looks good, but there are a bunch of unrelated changes here too?

Adding the stale.yml workflow and changing the secret scanning rules on some non-helia repos?

@whizzzkid
Copy link
Contributor Author

@achingbrain Interesting, I only added 7dd2a90 then a sneaky commit shows up as me: 82363f8

It's unverified, not me, the bot-overlords assumed my identity and pulled these shenanigans.

@achingbrain
Copy link
Member

Huh, weird - something similar happened in the libp2p/github-mgmt repo the other day.

@galargh @laurentsenta can this be prevented from happening?

@galargh
Copy link
Contributor

galargh commented Jan 3, 2024

I wrote down a longer reply in libp2p/github-mgmt#198.

Similarly to that case, here, #181 was left unattended for a while.

I filed an issue for commits that are incorrectly associated with real users - ipdxco/github-as-code#110

As for changing the existing behaviour, you could remove the pull_request_target trigger from https://github.com/ipfs/github-mgmt/blob/master/.github/workflows/fix.yml#L4. Without it, the fix workflow would only get triggered on pushes to the default branch.

@galargh galargh requested review from galargh and achingbrain and removed request for galargh January 8, 2024 12:42
Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, after this is merged, a new PR actually adding the template to all helia repos will get created.

@achingbrain
Copy link
Member

I'm about to archive most of the @helia/* repos as we're merging them into the main monorepo so this should probably be reduced in scope - ipfs/helia#363

@whizzzkid
Copy link
Contributor Author

@achingbrain so this should still be merged? Or should wait for the monorepo change? IIUC this can go in independent of that change.

@achingbrain
Copy link
Member

I would very much like no further commits to be pushed to the repos that are being merged into the main Helia monorepo.

@whizzzkid
Copy link
Contributor Author

whizzzkid commented Jan 8, 2024

Alright! @achingbrain I'll merge it once you're ready!

Edit: the merge is blocked on your review. Will merge when unblocked

@achingbrain
Copy link
Member

This should be good to go now!

@galargh
Copy link
Contributor

galargh commented Jan 9, 2024

I ran https://github.com/ipfs/github-mgmt/actions/workflows/sync.yml to pull in the repo archivisation actions into the state of this repository.

@SgtPooki
Copy link
Member

SgtPooki commented Feb 1, 2024

@lidel @achingbrain do either of you have merge permissions on this?

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved conflicts, merging.

@lidel lidel merged commit 19c8df7 into ipfs:master Feb 1, 2024
6 checks passed
@galargh galargh mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants