Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

WIP: Changes to reflect the fact that Provide/FindProviders use multhases. #18

Closed
wants to merge 1 commit into from

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Oct 29, 2018

@hannahhoward
Copy link
Contributor

hannahhoward commented Dec 19, 2018

@kevina is this PR still active? Is this part of your CID32 work? It seems like it's tied to a chain of open issues and I can't tell how close any are to merging.

Bitswap has been worked on quite a bit since this PR and there are several conflicts. I'm happy to work on updating this PR if you give me some guidance, cause I know you have a lot of work on your plate. Is it a situation where every time we currently reference a CID, we should reference a multihash instead? Or specifically and only when calling Provide/FindProvidersAsync?

@hannahhoward
Copy link
Contributor

Anyway, I see it's still WIP so I assume it's just an open issue for now, is there feedback I can offer that is helpful at this point? Or are you busy with other stuff and getting feedback on this PR is not a priority at the moment..

@kevina
Copy link
Contributor Author

kevina commented Dec 19, 2018

@hannahhoward yes p.r. is stalled on https://github.com/libp2p/go-libp2p-routing/issues/32 which doesn't have that great of a resolution, plus I lack detailed knowledge of the networking layer so I feel under-qualified to work on it. I hope to resume work on that issue sometime in January.

And yes it is part of the CID32 work.

@hannahhoward
Copy link
Contributor

Ok I'm going to close for now and we can re-open when we restart this work. I will not delete the branch. Is that ok @kevina?

@kevina
Copy link
Contributor Author

kevina commented Jan 10, 2019

@hannahhoward is there a reason you want to close this? It is unfinished work, yes, but it is labeled a WIP, it is also part of several other related P.R. and it doesn't make sense just to close this one.

I would prefer we keep this open until the underlying issue is closed.

@ghost ghost removed the status/in-progress In progress label Apr 30, 2019
@momack2 momack2 added this to Done in ipfs/go-ipfs May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants