Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Simulate DONT_HAVE when peer doesn't respond to want-block (new peers) #284

Merged
merged 2 commits into from Mar 10, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 10, 2020

We should simulate a DONT_HAVE response when we send want-block to a peer and the peer doesn't respond within a reasonable amount of time.

We have this already for older peers (that don't support DONT_HAVE).
This PR adds support for newer peers (that do support DONT_HAVE).

@dirkmc dirkmc requested a review from Stebalien March 10, 2020 20:07
@dirkmc dirkmc mentioned this pull request Mar 10, 2020
16 tasks
@dirkmc dirkmc changed the title Timeout when peer doesn't respond to want-block Simulate DONT_HAVE when peer doesn't respond to want-block (new peers) Mar 10, 2020
@dirkmc dirkmc mentioned this pull request Mar 10, 2020
@Stebalien Stebalien merged commit 3a82e57 into master Mar 10, 2020
@Stebalien Stebalien deleted the feat/dont-have-new-peers branch March 10, 2020 22:30
@dirkmc
Copy link
Contributor Author

dirkmc commented Mar 10, 2020

Verification that this branch performs better than the old bitswap:

Screen Shot 2020-03-10 at 6 41 53 PM

Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
…eers

Simulate DONT_HAVE when peer doesn't respond to want-block (new peers)

This commit was moved from ipfs/go-bitswap@3a82e57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants