This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
refactor: remove WantManager #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send CANCELs when session context is cancelled
Stebalien
approved these changes
Apr 23, 2020
Stebalien
reviewed
Apr 23, 2020
| } | ||
| } | ||
|
|
||
| return sessions | ||
| // Send CANCEL to all peers with want-have / want-block | ||
| sm.peerManager.SendCancels(ctx, blks) |
There was a problem hiding this comment.
TODO: I think we might want to do this first, but I'm not sure. Let's not move it yet but remember to revisit this.
There was a problem hiding this comment.
Agreed, I think we can probably even do this in parallel to commiting the block to the blockstore
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
refactor: remove WantManager This commit was moved from ipfs/go-bitswap@5643004
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.