This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
nil exchange is okay #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just use the offline exchange? https://github.com/ipfs/go-ipfs-exchange-offline |
|
this is about usability, someone wanting to use the blockservice (mostly because its a different interface than the blockstore) currently need to pull in some unknown extra package to fill out this field, just to tell the blockservice not to use it. Thats bad UX. |
|
We could also just pull the offline exchange into this package but you're right, this is bad UX and a nil exchange isn't exactly surprising. |
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…e-is-okay nil exchange is okay This commit was moved from ipfs/go-blockservice@ccbef01
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.