add a couple useful methods #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
May 1, 2020
cid.go
Outdated
|
|
||
| // WriteTo writes the cids bytes to the given writer | ||
| func (c Cid) WriteTo(w io.Writer) error { | ||
| _, err := io.WriteString(w, c.str) |
There was a problem hiding this comment.
worth checking if this has fully written the string?
There was a problem hiding this comment.
actually, probably better just to satisfy the WriterTo interface and return the write size
There was a problem hiding this comment.
this won't work with the IO methods unless it has a loop as i'm reading the interface contract.
It should either go until there's an error, or until it's written the full string - right?
ref: https://golang.org/pkg/io/#WriterTo
There was a problem hiding this comment.
mmm, i think youre right there.... Maybe i'll pick a different function name. I don't particularly care for loops here
Stebalien
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.