Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #142 #145

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Revert #142 #145

merged 2 commits into from
Sep 4, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Sep 4, 2022

Revert #142
Fixes #144

@Jorropo @rvagg If you reallly want to keep CodecToStr and Codecs, you should make sure they return hard error when someone tries to use them for impacted mappings above. Third-party people use this library. People don't read release notes. Silent data corruption is not acceptable.

I don't think this is doable other than removing CodecToStr.

An other solution is patching go-cid's map to present the old behaviour.

@Jorropo Jorropo requested a review from lidel September 4, 2022 13:44
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Suggested version: v0.3.2
Comparing to: v0.3.1 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 8731e34..44e2a51 100644
--- a/go.mod
+++ b/go.mod
@@ -2,7 +2,6 @@ module github.com/ipfs/go-cid
 
 require (
 	github.com/multiformats/go-multibase v0.0.3
-	github.com/multiformats/go-multicodec v0.5.0
 	github.com/multiformats/go-multihash v0.0.15
 	github.com/multiformats/go-varint v0.0.6
 )

gorelease says:

# github.com/ipfs/go-cid
## incompatible changes
CodecToStr: removed
Codecs: removed

# summary
Suggested version: v0.4.0

gocompat says:

(empty)

@Jorropo
Copy link
Contributor Author

Jorropo commented Sep 4, 2022

I know this is a semver violation but no one used v0.3.1 already so it's fine.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert as a quick fix to unblock Kubo sgtm.

@Jorropo
Copy link
Contributor Author

Jorropo commented Sep 4, 2022

For kubo Ill have to fix something to use go multicodec but that fine.

@Jorropo Jorropo merged commit 350d6af into master Sep 4, 2022
@Jorropo Jorropo deleted the Jorropo/patch-1 branch September 4, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodecToStr and Codecs in v0.3.1 could cause data corruption
2 participants