Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CidFromReader should not wrap valid EOF return. #151

Merged
merged 4 commits into from
Apr 4, 2023
Merged

CidFromReader should not wrap valid EOF return. #151

merged 4 commits into from
Apr 4, 2023

Commits on Apr 1, 2023

  1. CidFromReader should not wrap valid EOF return. 

    When reading from an io.Reader that has no data, the io.EOF error should not be wrapped in ErrInvalidCid. This is not an invalid CID, and is not the same as a partial read which is indicated by io.ErrUnexpectedEOF.

This fix is needed because existing code that uses CidFromReader may check for the end of an input stream by `if err == io.EOF` instead of the preferred `if errors.Is(err, io.EOF)`, and that code break at runtime after upgrading to go-cid v0.4.0.
    @gammazero
    gammazero committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    32fccdf View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Update cid.go 

    Co-authored-by: Rod Vagg <rod@vagg.org>
    @gammazero @rvagg
    gammazero and rvagg committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    215c310 View commit details
    Browse the repository at this point in the history

  2. Add unit test for unexpected eof

    @gammazero
    gammazero committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    84da254 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. v0.4.1

    @rvagg
    rvagg committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a245227 View commit details
    Browse the repository at this point in the history