Added map of string to codecs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
1 similar comment
Stebalien
reviewed
Jun 30, 2017
cid_test.go
Outdated
| for k, v := range tCodes { | ||
| if Codecs[v] != k { | ||
| t.Errorf("Table mismatch: 0x%x %s", k, v) | ||
| } |
There was a problem hiding this comment.
There should probably be a len(tCodes) == len(Codecs) - 1 test here.
There was a problem hiding this comment.
@Stebalien improved the tests. Added the one requested.
Kubuxu
reviewed
Jun 30, 2017
cid.go
Outdated
| @@ -79,6 +79,28 @@ const ( | |||
| ZcashTx = 0xc1 | |||
| ) | |||
|
|
|||
| // Codecs maps the name of a codec to its type | |||
| var Codecs = map[string]byte{ | |||
There was a problem hiding this comment.
I am not sure that byte is right format for it.
The codecs are not limited to a byte (due to varint) we just are trying to keep codecs that are being used in cid in the 8 bit range but it might not be much longer till we will have two byte CID codecs (we already have two and three byte multihashes).
There was a problem hiding this comment.
It should probably be uint64 as in https://github.com/ipfs/go-cid/blob/master/cid.go#L109
1 similar comment
Kubuxu
approved these changes
Jun 30, 2017
whyrusleeping
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Very useful for
ipfs block put --format <format> --mhtype <mhtype> <object>