Add support for querying entry expiration #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
bigs
approved these changes
Sep 12, 2018
magik6k
reviewed
Sep 12, 2018
| Limit int // maximum number of results | ||
| Offset int // skip given number of results | ||
| KeysOnly bool // return only keys. | ||
| ReturnExpirations bool // return expirations (see TTLDatastore) |
There was a problem hiding this comment.
@magik6k I considered GetExpirations, but discarded it because it implies that the impl may perform an extra lookup to populate the field, when in reality the spirit is to allow returning this value if its available in the iterator.
|
Thanks all. Holding off on merge until ipfs/go-ds-badger#32 is approved, to avoid breaking interfaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following:
GetExpirationfunction onTTLDatastore.ReturnExpirationsfield on query options.Expirationon query result object.The only implementation of the affected interface is go-ds-badger, and the PR to implement this functionality is here: ipfs/go-ds-badger#32