Add support for NextToLast shard function. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix bug when only the Prefix function was being tested in most cases.
|
Coverage increased (+0.8%) to 62.776% when pulling 4f600b596294122867eb4fe48e052c078f8055f3 on kevina/next-to-last into 9652294 on master. |
| @@ -30,6 +30,11 @@ func tempdir(t testing.TB) (path string, cleanup func()) { | |||
| return path, cleanup | |||
| } | |||
|
|
|||
| func tryAllShardFuncs(t *testing.T, testFunc func(mkShardFunc, *testing.T)) { | |||
| t.Run("prefix", func(t *testing.T) { testFunc(flatfs.Prefix, t) }) | |||
| t.Run("suffix", func(t *testing.T) { testFunc(flatfs.Suffix, t) }) | |||
There was a problem hiding this comment.
Should we put the NextToLast shardfunc here too?
There was a problem hiding this comment.
Oops. Thanks for catching this. I tend to interactively commit changes to avoid commiting the rewritten paths and missed this.
kevina
force-pushed
the
kevina/next-to-last
branch
from
4f600b5
to
0e6d035
Compare
|
Coverage increased (+0.8%) to 62.776% when pulling 0e6d035f405dbe45596915af3cabbc3311f6d64b on kevina/next-to-last into 9652294 on master. |
kevina
force-pushed
the
kevina/next-to-last
branch
from
0e6d035
to
d4844ef
Compare
This was referenced Dec 16, 2016
whyrusleeping
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.